Update issue templates #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnilgm
requested review from
georgekuruvillak and
shreyas-s-rao
as code owners
shreyas-s-rao
requested changes
Jan 30, 2019
There was a problem hiding this comment.
@swapnilgm Thanks for the PR! It's a much required feature for our repo. 🙂
I just have one suggestion. PTAL.
|
|
||
| **Expected behaviour:** | ||
| A clear and concise description of what you expected to happen. | ||
|
|
There was a problem hiding this comment.
Shall we have a "Current behaviour" section to let the issue-creator tell us exactly what problem they are experiencing, as opposed to what they expected to happen..?
There was a problem hiding this comment.
First section i.e. Describe the bug is exactly where issue raiser will right the current behaviour. And i don't think, we need to rename the section. @georgekuruvillak WDYT?
There was a problem hiding this comment.
Current behaviour is ambiguous. Describe the bug seems better to me.
georgekuruvillak
approved these changes
Jan 31, 2019
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.