-
Notifications
You must be signed in to change notification settings - Fork 101
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added member pkg for all etcd member manipulation functions
- Loading branch information
Showing
4 changed files
with
173 additions
and
199 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| package member | ||
|
|
||
| import ( | ||
| "context" | ||
| "os" | ||
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/gardener/etcd-backup-restore/pkg/etcdutil" | ||
| brtypes "github.com/gardener/etcd-backup-restore/pkg/types" | ||
| "github.com/sirupsen/logrus" | ||
| "go.etcd.io/etcd/etcdserver/api/v3rpc/rpctypes" | ||
| ) | ||
|
|
||
| const ( | ||
| // RetryPeriod is the peroid after which an operation is retried | ||
| RetryPeriod time.Duration = 5 * time.Second | ||
| ) | ||
|
|
||
| // AddMemberAsLearner add a member as a learner to the etcd cluster | ||
| func AddMemberAsLearner(logger *logrus.Logger) error { | ||
| //Add member as learner to cluster | ||
| memberURL := getMemberURL() | ||
| if memberURL == "" { | ||
| logger.Warn("Could not fetch member URL") | ||
| } | ||
| for { | ||
| //Create etcd client | ||
| //TODO: use ETCD_ENDPOINT env var passed by druid and use secure transport | ||
| clientFactory := etcdutil.NewFactory(brtypes.EtcdConnectionConfig{ | ||
| Endpoints: []string{"http://etcd-main-peer.default.svc:2380"}, //TODO: use ETCD_ENDPOINT env var passed by druid | ||
| InsecureTransport: true, | ||
| }) | ||
|
|
||
| memAddCtx, cancel := context.WithTimeout(context.TODO(), brtypes.DefaultEtcdConnectionTimeout) | ||
| cli, _ := clientFactory.NewCluster() | ||
| _, err := cli.MemberAddAsLearner(memAddCtx, []string{memberURL}) | ||
| cancel() | ||
| cli.Close() | ||
|
|
||
| if err != nil { | ||
| logger.Warn("Error adding member as a learner: ", err) | ||
| } | ||
| if err == nil || strings.Contains(rpctypes.ErrGRPCPeerURLExist.Error(), err.Error()) { | ||
| logger.Info("Added member to cluster as a learner") | ||
| break //TODO: why not just return here? | ||
| } | ||
| if strings.Contains(rpctypes.ErrGRPCPeerURLExist.Error(), err.Error()) { | ||
| logger.Info("Member already part of etcd cluster") | ||
| break | ||
| } | ||
|
|
||
| logger.Info("Could not as member as learner due to: ", err) | ||
| logger.Info("Trying again in 5 seconds... ") | ||
| timer := time.NewTimer(RetryPeriod) | ||
| <-timer.C | ||
| timer.Stop() | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // IsMemberInCluster checks is the current members peer URL is already part of the etcd cluster | ||
| func IsMemberInCluster(logger *logrus.Logger) bool { | ||
| //Create etcd client | ||
| // TODO: use ETCD_ENDPOINT env var passed by druid and use secure transport | ||
| clientFactory := etcdutil.NewFactory(brtypes.EtcdConnectionConfig{ | ||
| Endpoints: []string{"http://etcd-main-peer.default.svc:2380"}, //TODO: use ETCD_ENDPOINT env var passed by druid | ||
| InsecureTransport: true, //TODO: is it right to use insecure transport? | ||
| }) | ||
|
|
||
| // TODO: should use a retry mechanism here | ||
| cli, _ := clientFactory.NewCluster() | ||
| defer cli.Close() | ||
| logger.Info("Etcd client created") | ||
|
|
||
| // List members in cluster | ||
| memListCtx, cancel := context.WithTimeout(context.TODO(), brtypes.DefaultEtcdConnectionTimeout) | ||
| etcdMemberList, err := cli.MemberList(memListCtx) | ||
| defer cancel() | ||
| if err != nil { | ||
| logger.Warn("Could not list any etcd members", err) | ||
| return true | ||
| } | ||
|
|
||
| for _, y := range etcdMemberList.Members { | ||
| if y.Name == os.Getenv("POD_NAME") { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| func getMemberURL() string { | ||
| //end := strings.Split(os.Getenv("ETCD_ENDPOINT"), "//") //TODO: use ETCD_ENDPOINT env var passed by druid | ||
| memberURL := "http://" + os.Getenv("POD_NAME") + ".etcd-main-peer.default.svc:2380" | ||
| //memberURL := end[0] + "//" + os.Getenv("POD_NAME") + "." + end[1] | ||
| return memberURL | ||
| } | ||
|
|
||
| // PromoteMember promotes an etcd member from a learner to a voting member of the cluster. This will succeed only if its logs are caught up with the leader | ||
| func PromoteMember(ctx context.Context, logger *logrus.Entry) { | ||
| for { | ||
| // TODO: use ETCD_ENDPOINT env var passed by druid and use secure transport | ||
| clientFactory := etcdutil.NewFactory(brtypes.EtcdConnectionConfig{ | ||
| Endpoints: []string{"http://etcd-main-peer.default.svc:2380"}, //[]string{os.Getenv("ETCD_ENDPOINT")}, | ||
| InsecureTransport: true, | ||
| }) | ||
| cli, _ := clientFactory.NewCluster() | ||
|
|
||
| //List all members in the etcd cluster | ||
| //Member URL will appear in the memberlist call response as soon as the member has been added to the cluster as a learner | ||
| //However, the name of the member will appear only if the member has started running | ||
| memListCtx, memListCtxcancel := context.WithTimeout(context.TODO(), brtypes.DefaultEtcdConnectionTimeout) | ||
| etcdList, memListErr := cli.MemberList(memListCtx) | ||
| memListCtxcancel() | ||
|
|
||
| if memListErr != nil { | ||
| logger.Info("error listing members: ", memListErr) | ||
| cli.Close() | ||
| continue | ||
| } | ||
|
|
||
| //TODO: Simplify logic below | ||
| var promoted bool | ||
| promoted = false | ||
| for _, y := range etcdList.Members { | ||
| if y.Name == os.Getenv("POD_NAME") { | ||
| logger.Info("Promoting member ", y.Name) | ||
| memPromoteCtx, cancel := context.WithTimeout(context.TODO(), brtypes.DefaultEtcdConnectionTimeout) | ||
| cancel() | ||
| //Member promote call will succeed only if member is in sync with leader, and will error out otherwise | ||
| _, memPromoteErr := cli.MemberPromote(memPromoteCtx, y.ID) | ||
| if memPromoteErr == nil || strings.Contains(rpctypes.ErrGRPCMemberNotLearner.Error(), memPromoteErr.Error()) { | ||
| //Exit if member is successfully promoted or if member is not a learner | ||
| promoted = true | ||
| logger.Info("Member promoted ", y.Name, " : ", y.ID) | ||
| break | ||
| } | ||
| if strings.Contains(rpctypes.ErrGRPCMemberNotLearner.Error(), memPromoteErr.Error()) { | ||
| //Exit if member is already part of the cluster | ||
| promoted = true | ||
| logger.Info("Mmeber ", y.Name, " : ", y.ID, " already part of etcd cluster") | ||
| } | ||
| } | ||
| } | ||
| if promoted { | ||
| break | ||
| } | ||
|
|
||
| //Timer here so that the member promote loop doesn't execute too frequently | ||
| logger.Info("Member still catching up logs from leader. Retrying promotion...") | ||
| timer := time.NewTimer(RetryPeriod) | ||
| <-timer.C | ||
| timer.Stop() | ||
| } | ||
| } |
Oops, something went wrong.