Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Architecture" file from gardener/gardener repository #233

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Use "Architecture" file from gardener/gardener repository #233

merged 1 commit into from
Apr 23, 2021

Conversation

berendt
Copy link
Contributor

@berendt berendt commented Apr 22, 2021

Closes #231

Signed-off-by: Christian Berendt [email protected]

@berendt berendt requested a review from a team as a code owner April 22, 2021 11:44
@berendt
Copy link
Contributor Author

berendt commented Apr 22, 2021

Depends on gardener/gardener#3923.

@gardener-robot
Copy link

@berendt Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 22, 2021
@berendt
Copy link
Contributor Author

berendt commented Apr 23, 2021

/invite rfranzke

@gardener-robot
Copy link

@berendt Command "/invite rfranzke" failed with "Review cannot be requested from pull request author.".

Additional Information
Redacted in public. Check backend logs.

@berendt
Copy link
Contributor Author

berendt commented Apr 23, 2021

@rfranzke Can you please have a look on this one?

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 23, 2021
@rfranzke rfranzke merged commit 594084b into gardener:master Apr 23, 2021
@berendt berendt deleted the feat/gh-231 branch April 23, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Architecture.md from Github wiki to documentation git repository
3 participants