Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines for contributing bigger changes to CONTRIBUTING.md #223

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Mar 25, 2021

What this PR does / why we need it:
Add guidelines for contributing bigger changes to CONTRIBUTING.md

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
As agreed in the team retrospective meeting.

Release note:

NONE

@stoyanr stoyanr requested a review from a team as a code owner March 25, 2021 15:06
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 25, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great, thank you!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 26, 2021
Copy link
Contributor

@BeckerMax BeckerMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion.
/lgtm

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Max Becker <[email protected]>
@stoyanr
Copy link
Contributor Author

stoyanr commented Mar 29, 2021

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Mar 29, 2021
@BeckerMax
Copy link
Contributor

/lgtm

@stoyanr stoyanr merged commit 7d8002d into gardener:master Apr 1, 2021
@stoyanr stoyanr deleted the update-contributing-guidelines branch April 1, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge/squash Should be merged via 'Squash and merge' reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants