Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong handling of markdown links with src= or href= in URL #82

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix wrong handling of markdown links with src= or href= in URL #82

merged 1 commit into from
Nov 6, 2020

Conversation

g-pavlov
Copy link
Contributor

@g-pavlov g-pavlov commented Nov 5, 2020 •
edited
Loading

What this PR does / why we need it:
Fix failing processing of links that contain src= or href=

Which issue(s) this PR fixes:
Fixes #81

Release note:

Fixed an issue with failure to process documents with markdown links, which contain `src=` or `href=`

@g-pavlov g-pavlov added the component/documentation Gardener Documentation label Nov 5, 2020
@g-pavlov g-pavlov self-assigned this Nov 5, 2020
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 5, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2020
@g-pavlov g-pavlov force-pushed the fixspecialcharactersurl branch from d90feab to 1b66b57 Compare November 5, 2020 21:01
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2020
@g-pavlov g-pavlov changed the title fix wrong handling of MD links w/h src= fix wrong handling of markdown links with src= or href= in URL Nov 5, 2020
@g-pavlov g-pavlov merged commit 40d1065 into master Nov 6, 2020
@g-pavlov g-pavlov deleted the fixspecialcharactersurl branch November 6, 2020 10:14
@g-pavlov g-pavlov mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow Awaiting requested review from swilen-iwanow

Assignees

@g-pavlov g-pavlov

Labels
component/documentation Gardener Documentation needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

markdown links that contain src= or href= fail processing
5 participants
@g-pavlov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot