Fix trying to add to a not started workqueue #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes occasional
panic: Trying to add to a not started workqueue
Special notes for your reviewer:
The hypothesis is that download task enqueue was a go routine and did not block until done so the document worker could exit early. Occasionally that satisfied the conditions to shutdown the queues and the download tasks queue happened to be nil at the time the enqueue tries to add to the queue. The fix removes makes the document worker wait until the download task is added and overall the enqueue a bit more fault tolerant yet informative for the status of the operation.
Release note: