Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spell check #49

Merged
merged 1 commit into from
Oct 13, 2020
Merged

spell check #49

merged 1 commit into from
Oct 13, 2020

Conversation

g-pavlov
Copy link
Contributor

What this PR does / why we need it:
Adds support for GitHub wiki pages as sources for markdown. Now nodes can use contentSource sources such as https://github.com/gardener/documentation/wiki/Architecture.md.
Note the .md extension for the wiki resource. It is important to have it in order to successfully resolve this page to a GitHub raw resource and be able to read its markdown.

Which issue(s) this PR fixes:
Ads release notes for b945777

Special notes for your reviewer:
This adds just spell check changes mostly in comments and is mostly targeting to add release notes for the commit above which was erroneously added not as a PR.

Release note:

Documentation structures can now use GitHub wiki pages for `contentSource` source. The wiki page url has to end with `.md`. Example: `https://github.com/gardener/documentation/wiki/Architecture.md`

@g-pavlov g-pavlov added component/documentation Gardener Documentation kind/enhancement Enhancement, improvement, extension labels Oct 13, 2020
@g-pavlov g-pavlov self-assigned this Oct 13, 2020
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 13, 2020
@g-pavlov g-pavlov merged commit 4a9cbc1 into master Oct 13, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 13, 2020
@g-pavlov g-pavlov deleted the relnotes branch October 13, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow Awaiting requested review from swilen-iwanow

Assignees

@g-pavlov g-pavlov

Labels
component/documentation Gardener Documentation kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/review Needs review needs/second-opinion Needs second review by someone else reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-pavlov @gardener-robot-ci-3 @gardener-robot