Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gochecknoglobals and gocyclo linter #364

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add gochecknoglobals and gocyclo linter #364

merged 5 commits into from
Jan 7, 2025
+16 −35

Conversation

RadaBDimitrova
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova commented Dec 13, 2024 •
edited
Loading

What this PR does / why we need it:
The linter adds a check for global variables since they can result in code that is harder to understand and they can carry side-effects through an application that aren’t contained by the functions that use or rely on them. It also adds a linter for cyclomatic complexity.

Which issue(s) this PR fixes:
Part of #336

Special notes for your reviewer:
N/A

Release note:

`make verify` now checks for global variables and cyclomatic complexity too.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
@RadaBDimitrova RadaBDimitrova marked this pull request as ready for review December 13, 2024 07:12
ialidzhikov
ialidzhikov reviewed Dec 13, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2024
ialidzhikov
ialidzhikov reviewed Dec 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
ialidzhikov
ialidzhikov reviewed Dec 18, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@RadaBDimitrova RadaBDimitrova changed the title Add gochecknoglobals linter Add gochecknoglobals and gocyclo linter Dec 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 20, 2024
@ialidzhikov ialidzhikov self-requested a review January 6, 2025 09:20
Kostov6
Kostov6 reviewed Jan 7, 2025
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 7, 2025
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 7, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 7, 2025
Kostov6
Kostov6 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Kostov6 Kostov6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jan 7, 2025
@Kostov6 Kostov6 merged commit ce1aca6 into gardener:master Jan 7, 2025
10 checks passed
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Jan 7, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kostov6 Kostov6 Kostov6 approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RadaBDimitrova @ialidzhikov @Kostov6 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot