Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue in matching gardener/gardener... to gardener/gardener/ #360

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix issue in matching gardener/gardener... to gardener/gardener/ #360

merged 1 commit into from
Dec 6, 2024

Conversation

RadaBDimitrova
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova commented Dec 6, 2024 •
edited
Loading

What this PR does / why we need it:
Local.Accept() no longer matches gardener/gardener/ and any repository with gardener/gardener-<rest of the repo name>/

Which issue(s) this PR fixes:
Fixes #345

Special notes for your reviewer:
N/A

Release note:

Fixed resourceMapping for mappings with similar prefixes as gardener/gardener.

@RadaBDimitrova RadaBDimitrova marked this pull request as ready for review December 6, 2024 15:21
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 6, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
Kostov6
Kostov6 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@Kostov6 Kostov6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 added the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
@Kostov6 Kostov6 merged commit f2b64cd into gardener:master Dec 6, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kostov6 Kostov6 Kostov6 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected error when using local repositoryhost through resourceMappings
5 participants
@RadaBDimitrova @Kostov6 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot