Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base image from alpine to distroless and update go version to 1.17.12 #281

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Change base image from alpine to distroless and update go version to 1.17.12 #281

merged 2 commits into from
Aug 11, 2022

Conversation

dimityrmirchev
Copy link
Member

What this PR does / why we need it:
This PR changes the base image for docforge container from alpine to distroless. The process will now use a non root user for its execution. This will reduce the attack surface of the image.

It also updates go version to 1.17.12.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Docforge is now built using go version `1.17.12`.

Docforge now uses `distroless` as a base container image.

@dimityrmirchev dimityrmirchev requested a review from a team July 14, 2022 14:19
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 14, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2022
@Kostov6
Copy link
Contributor

Kostov6 commented Jul 15, 2022

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 15, 2022
@Kostov6 Kostov6 merged commit a1038d0 into gardener:master Aug 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimityrmirchev @Kostov6 @Kristian-ZH @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot