Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and minor changes #262

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Tests and minor changes #262

merged 1 commit into from
Jan 27, 2022

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Jan 27, 2022

What this PR does / why we need it:
Added git and github resource hander tests with coverage ~80%
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added git and github resource hander tests with coverage ~80%

@Kostov6 Kostov6 requested a review from a team January 27, 2022 08:42
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 27, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 27, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 27, 2022
dimitar-kostadinov
dimitar-kostadinov approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 27, 2022
@dimitar-kostadinov dimitar-kostadinov merged commit 546409b into gardener:master Jan 27, 2022
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Jan 27, 2022
@Kostov6 Kostov6 deleted the git_tests_coverage_expansion branch September 4, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kostov6 @dimitar-kostadinov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot