Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node selector rework #259

Merged
merged 2 commits into from
Jan 27, 2022
Merged

node selector rework #259

merged 2 commits into from
Jan 27, 2022

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Dec 23, 2021 •
edited
Loading

What this PR does / why we need it:
Reworks the git node selector

Release note:

The git node selector's missing argument processing has been added

@Kostov6 Kostov6 requested a review from a team December 23, 2021 14:57
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Dec 23, 2021
@gardener-robot
Copy link
Contributor

@Kostov6 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 23, 2021
Kristian-ZH
Kristian-ZH suggested changes Jan 4, 2022
View reviewed changes
Copy link

@Kristian-ZH Kristian-ZH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be rebased on the master branch.

Some minor comments

pkg/resourcehandlers/git/git_resource_handler.go Outdated Show resolved Hide resolved
pkg/resourcehandlers/github/resource_locator_cache.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 4, 2022
@Kostov6 Kostov6 force-pushed the git_node_selector_rework branch from 3b46868 to 27797a2 Compare January 4, 2022 13:33
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 4, 2022
@Kostov6
Copy link
Contributor Author

Kostov6 commented Jan 4, 2022

@Kostov6 Kostov6 closed this Jan 4, 2022
@Kostov6 Kostov6 reopened this Jan 4, 2022
@Kostov6 Kostov6 force-pushed the git_node_selector_rework branch from 27797a2 to 4179fb8 Compare January 11, 2022 07:28
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 27, 2022
@Kostov6 Kostov6 force-pushed the git_node_selector_rework branch from 9384617 to b9d77de Compare January 27, 2022 08:24
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 27, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 27, 2022
dimitar-kostadinov
dimitar-kostadinov approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jan 27, 2022
@gardener-robot gardener-robot removed needs/changes Needs (more) changes needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 27, 2022
@dimitar-kostadinov dimitar-kostadinov merged commit ff8800a into gardener:master Jan 27, 2022
@Kostov6 Kostov6 deleted the git_node_selector_rework branch September 4, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH requested changes

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kostov6 @gardener-robot @dimitar-kostadinov @Kristian-ZH @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3