Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ginkgo version feature tests #242

Merged
merged 2 commits into from
Nov 17, 2021
Merged

ginkgo version feature tests #242

merged 2 commits into from
Nov 17, 2021

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Nov 10, 2021 •
edited
Loading

What this PR does / why we need it:
Adds the ginkgo tests for the version feature

Special notes for your reviewer:
NewResourceHandlerExtended is added in the git handler to be able to set the fake Git from the test package

Release notes

Version feature tests are converted to Ginkgo tests
Code generation tool adds license headers to generated code files

@Kostov6 Kostov6 requested a review from a team November 10, 2021 08:03
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 2dba18b to 880e40d Compare November 10, 2021 08:10
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 880e40d to 2191633 Compare November 10, 2021 08:23
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 2191633 to 80c89c6 Compare November 10, 2021 08:43
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 80c89c6 to 1ca20c3 Compare November 10, 2021 08:47
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 1ca20c3 to cf93bcf Compare November 10, 2021 13:33
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from cf93bcf to 8040d53 Compare November 10, 2021 14:57
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 8040d53 to 11439ec Compare November 10, 2021 14:59
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2021
@Kristian-ZH Kristian-ZH mentioned this pull request Nov 12, 2021
Closed
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 12, 2021
@Kostov6 Kostov6 changed the title ginkgo tests ginkgo version feature tests Nov 12, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from fa8d616 to 54cd585 Compare November 16, 2021 13:16
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 16, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 16, 2021
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 16, 2021
@Kostov6 Kostov6 force-pushed the ginko_versions_test branch from 54cd585 to ce966bb Compare November 17, 2021 08:57
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2021
dimitar-kostadinov
dimitar-kostadinov approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 17, 2021
@dimitar-kostadinov dimitar-kostadinov merged commit 2fdd15a into gardener:master Nov 17, 2021
@Kostov6 Kostov6 deleted the ginko_versions_test branch November 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kostov6 @dimitar-kostadinov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot