Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config feature #237

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Oct 28, 2021

What this PR does / why we need it:
This PR adds the ability to specify the default branches and number of versions per manifest uri in the docforge config file

Example config file:

defaultBranches:
  https://github.com/Kostov6/scala/blob/DEFAULT_BRANCH/foo.yaml: foo
lastNVersions:
  https://github.com/Kostov6/documentation/blob/DEFAULT_BRANCH/.docforge/documentation.yaml: 3
  https://github.com/Kostov6/documentation/blob/DEFAULT_BRANCH/.docforge/documentationFoo.yaml: 4
  https://github.com/Kostov6/scala/blob/DEFAULT_BRANCH/foo.yaml: 3

Right now this is the priority that the specification of these parameters follow(highest to lowest):
Default branch: --main-branches {manifest}={branchName} -> config file -> --main-branches default={branchName} -> master
NVersions: --versions {manifest}={nVersions} -> config file -> --versions default={nVersions} -> 0

Which issue(s) this PR fixes:
Fixes #223

Special notes for your reviewer:
Some changes in the handler files are just code refactoring

Release note:

Default branches and number of versions can now be configured in the docforge config file

@Kostov6 Kostov6 requested a review from a team October 28, 2021 10:36
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Oct 28, 2021
@gardener-robot
Copy link
Contributor

@Kostov6 You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 28, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 28, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Nov 3, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 3, 2021
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 3, 2021
@dimitar-kostadinov dimitar-kostadinov merged commit b7907e3 into gardener:master Nov 3, 2021
@Kostov6 Kostov6 deleted the version-feature-config branch November 13, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple versions
5 participants