Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect node name collisions and throw an error #189

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Detect node name collisions and throw an error #189

merged 1 commit into from
Jul 6, 2021

Conversation

vlvasilev
Copy link
Contributor

What this PR does / why we need it:
When there is a container node that contains two or more nodes with the same name a warning is displayed.

Which issue(s) this PR fixes:
Fixes #184

Special notes for your reviewer:

Release note:

When collisions with node names collide, a warning is displayed.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 10, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2021
@vlvasilev vlvasilev force-pushed the detect-collisions branch from b2a8002 to 7e81674 Compare June 14, 2021 08:27
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 14, 2021
@vlvasilev vlvasilev force-pushed the detect-collisions branch from 7e81674 to 85aea63 Compare June 14, 2021 08:31
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 14, 2021
@vlvasilev vlvasilev changed the title Detect node name collisions and print warnning Detect node name collisions and return error Jun 14, 2021
@vlvasilev vlvasilev changed the title Detect node name collisions and return error Detect node name collisions and throw an error Jun 14, 2021
@vlvasilev
Copy link
Contributor Author

/assign @Kristian-ZH @swilen-iwanow

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 29, 2021
@JordanJordanov JordanJordanov merged commit 97a9aa8 into gardener:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

Assignees

@swilen-iwanow swilen-iwanow

@Kristian-ZH Kristian-ZH

Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation for nodes with duplicated names
8 participants
@vlvasilev @Kristian-ZH @gardener-robot-ci-1 @JordanJordanov @swilen-iwanow @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot