Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GH resource details to git info #171

Merged
merged 1 commit into from
Feb 15, 2021
Merged

add GH resource details to git info #171

merged 1 commit into from
Feb 15, 2021

Conversation

g-pavlov
Copy link
Contributor

@g-pavlov g-pavlov commented Feb 14, 2021 •
edited
Loading

What this PR does / why we need it:
Amends the produced gitinfo with details from the resource locator for which the gitinfo is generated.

Which issue(s) this PR fixes:
Fixes #170

Release note:

New properties `path`, `sha` and `shaalias` added to gitinfo generated for GitHub resources. The `path` property is the resource path in GitHub after resource type and its sha. `The `shaalias` property is the human readable tag/branch-name assigned to a sha (e.g. `master`).

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 14, 2021
@swilen-iwanow swilen-iwanow merged commit d380d76 into master Feb 15, 2021
@swilen-iwanow swilen-iwanow deleted the gitinfo branch February 15, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow Awaiting requested review from swilen-iwanow

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resource path and sha/sha alias to git info
5 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot