Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link removal #159

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix link removal #159

merged 1 commit into from
Feb 8, 2021

Conversation

g-pavlov
Copy link
Contributor

@g-pavlov g-pavlov commented Feb 5, 2021

What this PR does / why we need it:
Fixes positions offset during link removal.
Fixes links slice removals on the fly.
Propagates update callback errors.

Which issue(s) this PR fixes:
Fixes #158

Release note:

Fixes a runtime error when multiple links match a rewrite rule to be removed completely from a document.

@g-pavlov g-pavlov self-assigned this Feb 5, 2021
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 5, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 5, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2021
swilen-iwanow
swilen-iwanow reviewed Feb 8, 2021
View reviewed changes
pkg/markdown/parser/links.go Outdated Show resolved Hide resolved
pkg/markdown/links.go Outdated Show resolved Hide resolved
pkg/markdown/parser/document.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 8, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 8, 2021
@g-pavlov g-pavlov merged commit 454f161 into master Feb 8, 2021
@g-pavlov g-pavlov deleted the fix-remove-link branch February 8, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow swilen-iwanow approved these changes

Assignees

@g-pavlov g-pavlov

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing multiple completely yields runtime error
6 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot