Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes file comparison and rename #154

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fixes file comparison and rename #154

merged 1 commit into from
Jan 21, 2021

Conversation

g-pavlov
Copy link
Contributor

What this PR does / why we need it:
Fixes the comparison between actual file names and the ones specified in the flag
Adds removal of the original file upon rename situation.

Which issue(s) this PR fixes:
Fixes #153

Release note:

Fixes a bug when using the `--hugo-section-files` that did not result in rename of matching argument file names as expected.

@g-pavlov g-pavlov self-assigned this Jan 21, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 21, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 21, 2021
@g-pavlov g-pavlov force-pushed the fix-hugo-section-files branch from 1cfc2d0 to abb443d Compare January 21, 2021 11:22
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 21, 2021
swilen-iwanow
swilen-iwanow approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@swilen-iwanow swilen-iwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 21, 2021
@g-pavlov g-pavlov merged commit 9b5eb84 into master Jan 21, 2021
@g-pavlov g-pavlov deleted the fix-hugo-section-files branch January 21, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow swilen-iwanow approved these changes

Assignees

@g-pavlov g-pavlov

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The flag --hugo-section-files does not result in file rename
6 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot