Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prepend links in index files with "../" #149

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

swilen-iwanow
Copy link
Contributor

@swilen-iwanow swilen-iwanow commented Jan 19, 2021

What this PR does / why we need it:
Fixes a bug where relative links were rewritten wrong when using the --hugo flag (which also defaults the --hugo-pretty-links to true). This happens in cases where the node is "index file" meaning that hugo will not create a section out of it when building the website.
Which issue(s) this PR fixes:
Fixes #152

Special notes for your reviewer:

Release note:

Fixed a bug that was causing links of downloaded resources to be prepended with an extra `../`

@swilen-iwanow swilen-iwanow self-assigned this Jan 19, 2021
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 19, 2021
Copy link
Contributor

@g-pavlov g-pavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 19, 2021
@g-pavlov
Copy link
Contributor

Create an issue, link to this PR and add it to the project before merging

@g-pavlov g-pavlov merged commit d91f62e into master Jan 20, 2021
@swilen-iwanow swilen-iwanow deleted the index_files branch March 24, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong relative links when using the --hugo flag
5 participants