Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sanity check for links #131

Merged
merged 1 commit into from
Nov 23, 2020
Merged

add sanity check for links #131

merged 1 commit into from
Nov 23, 2020

Conversation

g-pavlov
Copy link
Contributor

What this PR does / why we need it:

  • Adds sanity check on parsed links before processing them and skips processing if no destination is found
  • Fixes incorrect usage for multierror that stored only the last entry in the multierror object

Which issue(s) this PR fixes:
Fixes #130

Release note:

Logs had entries like `-> abc`, which were result from text, incorrectly parsed text as links. Such incorrectly parsed links will no longer be processed as links.

Fixed reported errors from command execution. Previously many were logged but the few were reported as errors summary report at the end of the command execution.

@g-pavlov g-pavlov self-assigned this Nov 22, 2020
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 22, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2020
swilen-iwanow
swilen-iwanow approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@swilen-iwanow swilen-iwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020
@g-pavlov g-pavlov merged commit bfa18ab into master Nov 23, 2020
@g-pavlov g-pavlov deleted the linkssanitycheck branch November 23, 2020 10:31
@g-pavlov g-pavlov mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow swilen-iwanow approved these changes

Assignees

@g-pavlov g-pavlov

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text parsed incorrectly as links gets processed
5 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot