Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add http log #129

Merged
merged 1 commit into from
Nov 23, 2020
Merged

add http log #129

merged 1 commit into from
Nov 23, 2020

Conversation

g-pavlov
Copy link
Contributor

What this PR does / why we need it:
Adds http logging middleware wrapper around the http client transport.

I1122 21:50:05.805781  313799 factory.go:192] HTTP GET https://api.github.com/repos/gardener/documentation/git/blobs/791942ffd90f56311b72beb1b8729d4028b028c7 200 OK
I1122 21:50:05.894353  313799 factory.go:192] HTTP GET https://api.github.com/repos/gardener/documentation/git/trees/master?recursive=1 200 OK

Which issue(s) this PR fixes:
Fixes #128

Release note:

With verbosity flag >= 6 enabled (`-v=6`), now logs contain also HTTP logs. The logs are simple and consist of the request method, URL and response status.

@g-pavlov g-pavlov self-assigned this Nov 22, 2020
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 22, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2020
swilen-iwanow
swilen-iwanow approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@swilen-iwanow swilen-iwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! /lgtm

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 23, 2020
@g-pavlov g-pavlov merged commit c147833 into master Nov 23, 2020
@g-pavlov g-pavlov deleted the addhttplog branch November 23, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow swilen-iwanow approved these changes

Assignees

@g-pavlov g-pavlov

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP log
5 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot