Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for the core reactor's logic that resolves the documentation structure nodesSelector #112

Closed
swilen-iwanow opened this issue Nov 17, 2020 · 0 comments · Fixed by #108
Closed

Missing tests for the core reactor's logic that resolves the documentation structure nodesSelector #112

swilen-iwanow opened this issue Nov 17, 2020 · 0 comments · Fixed by #108
Assignees
@swilen-iwanow
Labels
effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)

Comments

@swilen-iwanow
Copy link
Contributor

swilen-iwanow commented Nov 17, 2020 •
edited
Loading

Test coverage of the reactor package has to be improved.
@swilen-iwanow swilen-iwanow added kind/enhancement Enhancement, improvement, extension priority/normal size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 17, 2020
@swilen-iwanow swilen-iwanow self-assigned this Nov 17, 2020
@swilen-iwanow swilen-iwanow changed the title Break circular dependency when resolving nested nodes selectors Missing tests for the core reactor's logic that resolves the documentation structure nodesSelector Nov 17, 2020
@swilen-iwanow swilen-iwanow linked a pull request Nov 26, 2020 that will close this issue
break cycling dependenciec with a warning #108
Merged
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) effort/2d Effort for issue is around 2 days and removed priority/normal size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swilen-iwanow swilen-iwanow

Labels
effort/2d Effort for issue is around 2 days kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

break cycling dependenciec with a warning gardener/docforge
2 participants
@swilen-iwanow @gardener-robot