Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openMFP] Move luigiContext and isInIframe to own composables #2223

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[openMFP] Move luigiContext and isInIframe to own composables #2223

merged 4 commits into from
Dec 10, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
Move luigiContext and isInIframe to own composables

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 6, 2024
holgerkoser
holgerkoser reviewed Dec 9, 2024
View reviewed changes
frontend/src/App.vue Outdated Show resolved Hide resolved
frontend/src/composables/useOpenMFP.js Outdated Show resolved Hide resolved
frontend/src/App.vue Outdated Show resolved Hide resolved
frontend/src/router/guards.js Outdated Show resolved Hide resolved
frontend/src/router/guards.js Show resolved Hide resolved
holgerkoser
holgerkoser approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 10, 2024
@petersutter petersutter merged commit 8754a10 into openmfp Dec 10, 2024
4 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 10, 2024
@petersutter petersutter deleted the luigi-context-composable branch December 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot