Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lint-sarif script to output lint results in SARIF format #2210

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Nov 28, 2024

What this PR does / why we need it:
This PR introduces new lint-sarif scripts for all packages. It uses @microsoft/eslint-formatter-sarif formatter to output lint scanning results in SARIF format. This is required to report the results to central SAST tools.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 28, 2024
backend/package.json Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 29, 2024
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit e5454a4 into master Dec 2, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 2, 2024
holgerkoser added a commit that referenced this pull request Dec 3, 2024
* master:
  Update yarn `prod-install` plugin sources (#2212)
  Move polling watcher to own package (#2208)
  Update dependency vuetify to v3.7.5 (#2216)
  Update dependency vite to v6 (#2214)
  fix tests (#2215)
  Update Monthly Dev Dependencies (#2213)
  Optimize CodeMirror Integration with Dynamic Imports (#2206)
  Added lint-sarif script to output lint results in SARIF format (#2210)
  Update dependency @codemirror/language to v6.10.6 (#2211)
  Update dependency pinia to v2.2.8 (#2209)
  Update vueuse monorepo to v12 (#2203)
  migrate to polling watcher (remove chokidar) (#2202)
  Update dependency pinia to v2.2.7 (#2205)
  Update dependency @codemirror/language to v6.10.5 (#2204)

# Conflicts:
#	.pnp.cjs
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants