-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pass authtoken-lookup to deliveryservice-client #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
the
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
label
Dec 19, 2024
ccwienk
force-pushed
the
refactor-for-gha
branch
from
December 19, 2024 09:11
4b072bf
to
6443ba3
Compare
ccwienk
force-pushed
the
refactor-for-gha
branch
from
December 19, 2024 09:15
6443ba3
to
e7b7faf
Compare
ccwienk
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Dec 19, 2024
Adjust to upstream refactoring from: gardener/cc-utils#1102
zkdev
requested changes
Dec 19, 2024
Remove dependency from deliveryservice-client towards Gardener-CICD / cfg-factory. Define authtoken-lookup, and pass it to deliveyservice-client, rather than cfg-factory.
ccwienk
force-pushed
the
refactor-for-gha
branch
from
December 19, 2024 11:47
e7b7faf
to
f1931cf
Compare
zkdev
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/changes
Needs (more) changes
labels
Dec 19, 2024
gardener-robot
added
status/closed
Issue is closed (either delivered or triaged)
and removed
needs/review
Needs review
labels
Dec 19, 2024
ccwienk
added a commit
to open-component-model/delivery-service
that referenced
this pull request
Dec 19, 2024
Adjust to upstream refactoring from: gardener/cc-utils#1102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
reviewed/lgtm
Has approval for merging
size/s
Size of pull request is small (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency from deliveryservice-client towards Gardener-CICD / cfg-factory. Define authtoken-lookup, and pass it to deliveyservice-client, rather than cfg-factory.