Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass authtoken-lookup to deliveryservice-client #1102

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 19, 2024

Remove dependency from deliveryservice-client towards Gardener-CICD / cfg-factory. Define authtoken-lookup, and pass it to deliveyservice-client, rather than cfg-factory.

@gardener-robot gardener-robot added the needs/review Needs review label Dec 19, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Dec 19, 2024
ccwienk added a commit to open-component-model/delivery-service that referenced this pull request Dec 19, 2024
delivery/client.py Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Dec 19, 2024
Remove dependency from deliveryservice-client towards Gardener-CICD /
cfg-factory. Define authtoken-lookup, and pass it to
deliveyservice-client, rather than cfg-factory.
Copy link
Member

@zkdev zkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ccwienk ccwienk merged commit f023cbc into master Dec 19, 2024
11 checks passed
@ccwienk ccwienk deleted the refactor-for-gha branch December 19, 2024 11:50
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Dec 19, 2024
@gardener-robot gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Dec 19, 2024
ccwienk added a commit to open-component-model/delivery-service that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants