More refactorings #1099
Merged
More refactorings #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an intermediate step towards resolving dependencies from release_notes package towards gardener-cicd / concourse-template, pull-up nested lookups for gitutil-instances, and instead pass them in as parameter. GitUtil still holds a reference to `model.github.GitHubCfg`. This will be resolved in a subsequent change.
gardener-robot
added
needs/review
gardener-robot
added
the
size/l
gardener-robot
added
needs/second-opinion
ccwienk
force-pushed
the
more-refactorings
branch
from
4e50ddc to
f262aa0
Compare
Define new type `GitCfg`, which specifies minimal cfg (username + email address, remote-url, credentials) for retrieving and / or interacting with a git-repository with a remote. In pipeline-template / code intended to be run within Gardener-CICD, derive such GitCfgs from GitHubConfig. This change will ultimately allow creation of GitHelpers also in environments outside of Gardener-CICD (for example GitHub-Actions). As GitUtil is used by `release_notes`, which is planned to be re-used in GitHub-Actions, this is a preliminary step towards that.
ccwienk
force-pushed
the
more-refactorings
branch
from
f262aa0 to
aabdd80
Compare
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more refactorings towards making gitutil/github/release_notes packages less interwoven w/ gardener-cicd (more to follow)