Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge DeliveryCfg #1094

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Purge DeliveryCfg #1094

merged 1 commit into from
Dec 10, 2024

Conversation

zkdev
Copy link
Member

@zkdev zkdev commented Dec 9, 2024

Was mved to delivery-service in order to (further) decouple ocm-gear from cc-utils.

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:


Was mved to delivery-service in order to (further) decouple
ocm-gear from cc-utils.
@zkdev zkdev requested review from ccwienk and 8R0WNI3 as code owners December 9, 2024 09:14
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 9, 2024
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 9, 2024
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this break ccc.delivery?

@zkdev
Copy link
Member Author

zkdev commented Dec 9, 2024

won't this break ccc.delivery?

Why would it?
ccc.delivery only relies on delivery_endpoints cfg, which is decoupled from delivery cfg 🤔

@ccwienk
Copy link
Member

ccwienk commented Dec 9, 2024

okay, if you checked / are sure, then nvm

@zkdev zkdev merged commit 0020c5b into master Dec 10, 2024
12 checks passed
@zkdev zkdev deleted the zkdev-purge-delivery-cfg branch December 10, 2024 09:26
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants