Support scale to/from zero for MCM OOT providers - AWS, Azure #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6e9be31ee4041e2dfaf428b7b7202c7942cc (dbf66e9)
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/invite @hardikdr @AxiomSamarth |
|
/priority critical |
gardener-robot
added
the
priority/critical
AxiomSamarth
approved these changes
Dec 7, 2020
|
/invite @amshuman-kr |
amshuman-kr
suggested changes
Dec 7, 2020
There was a problem hiding this comment.
Thanks for the PR @prashanth26. Only one main question below. Could be a stupid question and I might be lacking the context.
gardener-robot-ci-3
added
reviewed/ok-to-test
amshuman-kr
approved these changes
Dec 7, 2020
hardikdr
approved these changes
Dec 7, 2020
prashanth26
added a commit
to prashanth26/autoscaler
that referenced
this pull request
Dec 8, 2020
Refer below PRs for fetched files - gardener#65 - gardener/machine-controller-manager#384
prashanth26
added a commit
to prashanth26/autoscaler
that referenced
this pull request
Dec 8, 2020
Refer below PRs for fetched files - gardener#65 - gardener/machine-controller-manager#384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This allows MCM OOT providers - AWS and Azure to use the scale-to/from-zero feature.
Which issue(s) this PR fixes:
Fixes #57
Special notes for your reviewer:
Release note: