Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync upstream v1.26.0 #184

Merged
merged 259 commits into from
Mar 12, 2023
Merged

Sync upstream v1.26.0 #184

merged 259 commits into from
Mar 12, 2023

Conversation

elankath
Copy link

@elankath elankath commented Mar 6, 2023

What this PR does / why we need it:
Syncs the autoscaler with upstream v1.26.0

Which issue(s) this PR fixes:
Fixes #158

Special notes for your reviewer:

Note: This version is crashing upstream, so our version would also crash. But since we keep our minor version in sync so we have synced it. As we can't have new features in a patch release like 1.26.1

Release note:

Synced the changes till v1.26.0 of upstream autoscaler
`mcmCloudProvider` now implements new method: `HasInstance(*apiv1.Node) (bool, error)` . Currently basic implementation in place.
We advise not to use this version but v1.26.1 , as the upstream v1.26.0 crashes due to a bug , which is fixed in 1.26.1 . We have synced this version to keep in line with the syncing procedure which has been followed till now.

x13n and others added 30 commits September 1, 2022 15:16
Update go.mod version for github.com/google/go-cmp from 0.5.6 to 0.5.8
Increase timeout for VPA `v1` e2e tests
After kubernetes#5151 e2e are still failing because we're still hitting ginkgo timeout
feat: add support for metricRelabelings
Change VPA default version to 0.12.0
…score-tags

Azure: support node label keys having underscores
Extract scale down eligibility checking to a separate object
The fact that it only considers nodes as deleted only until a certain
timeout is of no concern to the eligibility.Checker.
Don't depend on IsNodeBeingDeleted implementation
Allow simulator to persist changes in cluster snapshot
This filtering was used for two purposes:
- Excluding masters from destination candidates
- Excluding masters from calculating cluster resources

Excluding from destination candidates isn't useful: if pods can schedule
there, they will, so removing them from CA simulation doesn't change
anything.
Excluding from calculating cluster resources actually matches scale up
behavior, where master nodes are treated the same way as regular nodes.
@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 15 committers have signed the CLA.

✅ elankath
❌ fookenc
❌ k8s-ci-robot
❌ yaroslava-serdiuk
❌ xval2307
❌ yznima
❌ jbartosik
❌ gjtempleton
❌ BigDarkClown
❌ yasinlachiny
❌ 24601
❌ ctrox
❌ x13n
❌ towca
❌ MaciekPytel
You have signed the CLA already but the status is still pending? Let us recheck it.

@gardener-robot gardener-robot added the needs/review Needs review label Mar 6, 2023
@gardener-robot-ci-3
Copy link

Thank you @elankath for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 6, 2023
@elankath elankath added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 7, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 7, 2023
@elankath elankath added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 7, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 7, 2023
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 10, 2023
@himanshu-kun himanshu-kun merged commit 5c55843 into gardener:machine-controller-manager-provider Mar 12, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☂️ Issue for - Sync with Upstream v1.26