Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream v1.22.3 #131

Merged
merged 43 commits into from
Jun 25, 2022

Conversation

himanshu-kun
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Gardener autoscaler now in sync with upstream v1.22.3

bpineau and others added 30 commits August 16, 2021 16:30
While this was previously effectively limited to 50, `DescribeAutoScalingGroups` now supports
fetching 100 ASG per calls on all regions, matching what's documented:
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DescribeAutoScalingGroups.html
```
     AutoScalingGroupNames.member.N
       The names of the Auto Scaling groups.
       By default, you can only specify up to 50 names.
       You can optionally increase this limit using the MaxRecords parameter.
     MaxRecords
       The maximum number of items to return with this call.
       The default value is 50 and the maximum value is 100.
```

Doubling this halves API calls on large clusters, which should help to prevent throttling.
Refactor to allow for optimisation
The pricing json for us-east-1 is currently 129MB. Currently fetching
this into memory and parsing results in a large memory footprint on
startup, and can lead to the autoscaler being OOMKilled.

Change the ReadAll/Unmarshal logic to a stream decoder to significantly
reduce the memory use.
…pick-of-#3999-kubernetes#4199-upstream-cluster-autoscaler-release-1.22

Automated cherry pick of kubernetes#3999 kubernetes#4199 upstream cluster autoscaler release 1.22
Magnum allows using the microversion string "latest",
and it will replace it internally with the highest
microversion that it supports.

This will let the autoscaler use microversion 1.10 which
allows scaling groups to 0 nodes, if it is available.

The autoscaler will still be able to use microversion 1.9
on older versions of magnum.
Cherry pick kubernetes#4261 (magnum microversion) to cluster-autoscaler-release-1.22
Backport Merge pull request kubernetes#4274 to upstream/cluster-autoscaler-release-1.22
Signed-off-by: Sylvain Rabot <[email protected]>
…ist-Update-03-10-21-1.22

CA - AWS - Instance List Update 03-10-21 - 1.22 release branch
…lease-1.22

CA - AWS - Instance List Update 29-10-21 - 1.22 release branch
…elease-1.22

Cherry-pick kubernetes#4497 onto 1.22 - add more azure instance types
…ist-Update-29-11-21-1.22

Cluster-Autoscaler update AWS EC2 instance types with g5, m6 and r6 - 1.22 release branch
…ist-Update-13-12-21-1.22

CA - AWS Instance List Update - 13/12/21 - 1.22
…pick-of-#4539-upstream-cluster-autoscaler-release-1.22

[release-1.22] Automated cherry pick of kubernetes#4539: Add `--feature-gates` flag to support scale up on volume
Fix Azure IMDS Url in InstanceMetadataService initialization
Remove variables not used in azure_util_test
m-craghead and others added 11 commits April 7, 2022 11:26
corrected the azure_kubernetes_ercice_pool_test unit test cases involving the changed tag prefix

added const aksManagedPoolName attribute to the top of the code and fixed file name sercice -> service

added logic for old clusters that still have poolName

added legacy tag for poolName

Fixed Autoscaling due to VMSS tag prefix issue, added tags for legacy poolName and aksManagedPoolName, and corrected file name sercice->service
…o-cherry-picks

Cherry-pick kubernetes#4421, kubernetes#4550 - Azure scale from zero improvements
…x-CherryPick-release-1.22

fix autoscaling due to VMSS tag prefix issue - Cherry Pick into release 1.22
Instead of logging a fatal error, log a standard error and fall back to
loading instance types from the static list.
…ease-1.22-aws-fallback

CA - AWS Cloud Provider - 1.22 - fix instance type fallback
…r-release-1.22-aws-instance-update-02-06-2022

CA - AWS Cloud Provider - 1.22 Static Instance List Update 02-06-2022
…r-release-1.22.3

Cluster Autoscaler - 1.22.3 release
@himanshu-kun himanshu-kun requested review from hardikdr and a team as code owners June 24, 2022 07:18
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 24, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 24, 2022
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 16 committers have signed the CLA.

✅ ialidzhikov
✅ himanshu-kun
❌ bpineau
❌ k8s-ci-robot
❌ aidy
❌ tghartland
❌ towca
❌ sylr
❌ gjtempleton
❌ marwanad
❌ lzhecheng
❌ MaciekPytel
❌ whites11
❌ sturman
❌ m-craghead
❌ tzneal
You have signed the CLA already but the status is still pending? Let us recheck it.

@himanshu-kun
Copy link
Author

/invite @ialidzhikov

1 similar comment
@himanshu-kun
Copy link
Author

/invite @ialidzhikov

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jun 24, 2022
@himanshu-kun himanshu-kun merged commit 4ee83bf into gardener:rel-v1.22 Jun 25, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 25, 2022
@himanshu-kun himanshu-kun deleted the rel-v1.22-prep branch June 25, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.