Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Fix 431 PR merge #456

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix 431 PR merge #456

merged 1 commit into from
Nov 20, 2020

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented Nov 20, 2020

What this PR does / why we need it:
It resolves PR 431 merge by using the latest GetFromTargetInfo() method in logsVpnSeed()

Which issue(s) this PR fixes:
Fixes #455

Special notes for your reviewer:

  • none
    Release note:
- Make logsVpnSeed() use the latest GetFromTargetInfo() method

@jguipi jguipi requested a review from a team as a code owner November 20, 2020 16:07
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 20, 2020
@jguipi jguipi self-assigned this Nov 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2020
@jguipi jguipi assigned neo-liang-sap and unassigned jguipi Nov 20, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2020
@dansible
Copy link
Contributor

dansible commented Nov 20, 2020

The pipeline is giving this error, can you take a look?

Step 2/17 : RUN mkdir -p /go/src/github.com/gardener/gardenctl &&    cd /go/src/github.com/gardener &&    git clone https://github.com/gardener/gardenctl.git &&    cd ./gardenctl &&    CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -installsuffix cgo -o gardenctl cmd/gardenctl/main.go

 ---> Running in 6776b5611bb7

Cloning into 'gardenctl'...

# github.com/gardener/gardenctl/pkg/cmd

pkg/cmd/logs.go:583:22: undefined: getFromTargetInfo

The command '/bin/sh -c mkdir -p /go/src/github.com/gardener/gardenctl &&    cd /go/src/github.com/gardener &&    git clone https://github.com/gardener/gardenctl.git &&    cd ./gardenctl &&    CGO_ENABLED=0 GOOS=linux go build -mod=vendor -a -installsuffix cgo -o gardenctl cmd/gardenctl/main.go' returned a non-zero code: 2

Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the error is referencing the current master code. Let's merge and retry

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 20, 2020
@dansible dansible merged commit 14cc792 into gardener-attic:master Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/cmd/logs.go:583:22: undefined: getFromTargetInfo
5 participants