Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

allow pass args to ssh openstack node #424

Merged
merged 1 commit into from
Nov 10, 2020
Merged

allow pass args to ssh openstack node #424

merged 1 commit into from
Nov 10, 2020

Conversation

neo-liang-sap
Copy link
Contributor

What this PR does / why we need it:
allow pass args to ssh openstack node
Which issue(s) this PR fixes:
Fixes #417

Special notes for your reviewer:
tested with gardenctl ssh openstack_node exit and gardenctl ssh openstack_node echo true

image
image

Release note:

allow pass args to ssh openstack node

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner November 3, 2020 02:15
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 3, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 3, 2020
dansible
dansible approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@dansible dansible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @neo-liang-sap 👍

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 9, 2020
@neo-liang-sap neo-liang-sap merged commit 49989fa into gardener-attic:master Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dansible dansible dansible approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing custom arguments to gardenctl ssh <openstack_node>
4 participants
@neo-liang-sap @dansible @gardener-robot-ci-2 @gardener-robot