This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
refactor functions and add test case in miscellaneous.go & miscellaneous_test.go and others which impacted #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
7b91c72
to
9168a32
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
9168a32
to
51a8ab6
Compare
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
dansible
suggested changes
Oct 21, 2020
gardener-robot
added
needs/changes
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
51a8ab6
to
c95357d
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
c95357d
to
925cbe0
Compare
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
925cbe0
to
3de008b
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
3de008b
to
8edeb72
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
tedteng
changed the title
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
8edeb72
to
617b84e
Compare
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
617b84e
to
d665457
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
d665457
to
4660839
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
f188b66
to
7bc9636
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
7bc9636
to
e47a35c
Compare
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
according to discussion in planning mtg this PR is done, right? @dansible could you please approve this PR and i will perform merge? thanks! |
|
So far so good, I just wanted to go through a review of the changes with @tedteng in person. We will have a call at 10AM Friday your time for this - I've asked Ted to send you an invite in case you'd like to join also |
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
e47a35c
to
380117f
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
@dansible done adding extra tests in |
dansible
suggested changes
Nov 13, 2020
pkg/cmd/miscellaneous_test.go
Outdated
| }) | ||
| }) | ||
|
|
||
| Context("GetTargetName garden", func() { |
There was a problem hiding this comment.
is this a duplicate test?
There was a problem hiding this comment.
right, just removed
tedteng
force-pushed
the
add_test_miscellaneous
branch
2 times, most recently
from
bff9c6a
to
d1955d6
Compare
|
@dansible fixed the conflict. Please let me know is anything else need to change it thanks |
|
Thanks @tedteng - there are just some conflicts in the |
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
d1955d6
to
92e25f8
Compare
|
@dansible done |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
refactor methods able to use go test framework fix nonexisting return and use PrintoutObject add GetTargetedxxxObject fix loop issue add getRole targetReader interface modify GetXXXObject fix no kind ShootList fix getRole == user
tedteng
force-pushed
the
add_test_miscellaneous
branch
from
92e25f8
to
95abd63
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
dansible
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After a series of different experiments, to compatible the existing go test suits (*_test.go) and use it in the future test case. I have to refactor isTargeted,getTargetName,getSeedObject,getShootObject,`getProjectObject'
meanwhile, also add new test cases for those methods in miscellaneous_test.go as much as I can. add more local integration test to verify the refactor
Which issue(s) this PR fixes:
Fixes #403
Special notes for your reviewer:
Release note: