-
Notifications
You must be signed in to change notification settings - Fork 42
aws.go az.go gcloud.go #391
aws.go az.go gcloud.go #391
Conversation
I think for this to be merged, it would need to take into account the changes in the hotfix with trimming and cleaning up the arg list: |
sure, didn't saw the PR already meged .will fetch the latest code and trimming and cleaning up the argllist |
6b97fda
to
1aea84a
Compare
AWS SSH and subcommand aws cli veirfy - PASS
|
Az SSH & subcommand az cli -- PASS
|
GCP SSH -Pass but gcloud cli -failure.
|
after checked at least from v21 the gcloud issue already exist open the issue ticket. #396 ./gardenctl-darwin-amd64 gcloud compute instances list |
3604b42
to
2a5848c
Compare
The .ci/test is only a temporary solution before we found a new solution as we lack knowledge about ginkgo & gomega now to achieve the goal. I hope we can use ginkgo & gomega in the future. to use test shell script on local & check before commit |
add test case for aws/az/gcloud cli
2a5848c
to
8f7d467
Compare
/LGTM |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #389
Fixes #395
Special notes for your reviewer:
Release note: