Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

aws.go az.go gcloud.go #391

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

tedteng
Copy link
Contributor

@tedteng tedteng commented Oct 16, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #389
Fixes #395

Special notes for your reviewer:

Release note:


@tedteng tedteng requested a review from a team as a code owner October 16, 2020 13:56
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 16, 2020
@dansible
Copy link
Contributor

I think for this to be merged, it would need to take into account the changes in the hotfix with trimming and cleaning up the arg list:
https://github.com/gardener/gardenctl/pull/390/files

@tedteng
Copy link
Contributor Author

tedteng commented Oct 16, 2020

I think for this to be merged, it would need to take into account the changes in the hotfix with trimming and cleaning up the arg list:
https://github.com/gardener/gardenctl/pull/390/files

sure, didn't saw the PR already meged .will fetch the latest code and trimming and cleaning up the argllist

@tedteng tedteng closed this Oct 19, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@tedteng tedteng reopened this Oct 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@tedteng tedteng changed the title aws.go az.go gcloud.go [WIP]aws.go az.go gcloud.go Oct 19, 2020
@tedteng
Copy link
Contributor Author

tedteng commented Oct 19, 2020

AWS SSH and subcommand aws cli veirfy - PASS

gg aws -- --version                                
aws-cli/2.0.40 Python/3.8.5 Darwin/19.6.0 source/x86_64
gg ssh ip-10-250-26-3.eu-central-1.compute.internal                             

Warning:
Be aware that you are entering an untrusted environment!
Do not enter credentials or sensitive data within the ssh session that cluster owners should not have access to.

Downloaded id_rsa key
Check Public IP

(1/4) Fetching data from target shoot cluster
Data fetched from target shoot cluster.

(2/4) Setting up bastion host security group
Bastion host security group set up.

(3/4) Creating bastion host and node host security group
Bastion host instance i-007e588024f752b21 Initializing.

Bastion host instance running.
Opened SSH Port on Node.
Waiting 60 seconds for Bastion SSH port open
=> nc: connectx to 18.184.113.54 port 22 (tcp) failed: Connection refused

=> nc: connectx to 18.184.113.54 port 22 (tcp) failed: Connection refused

=> Connection to 18.184.113.54 port 22 [tcp/*] succeeded!

Opened SSH Port on Bastion
SSH [email protected] => [email protected]
Warning: Permanently added '18.184.113.54' (ED25519) to the list of known hosts.
Warning: Permanently added 'ip-10-250-26-3.eu-central-1.compute.internal' (ED25519) to the list of known hosts.
  ____               _              _     _                  
 / ___| __ _ _ __ __| | ___ _ __   | |    _ _ __  _   ___  __
| |  _ / _` | '__/ _` |/ _ \ '_ \  | |   | | '_ \| | | \ \/ /
| |_| | (_| | | | (_| |  __/ | | | | |___| | | | | |_| |>  < 
 \____|\__,_|_|  \__,_|\___|_| |_| |_____|_|_| |_|\__,_/_/\_\
Garden Linux 11 (based on Debian GNU/Linux 11)               

Welcome to ip-10-250-26-3.eu-central-1.compute.internal  Mon Oct 19 06:32:15 UTC 2020
Linux #1 SMP Debian 5.4.19-1 (2020-02-13) x86_64 up 18 hours, 22 minutes
Load:  0.12, 0.19, 0.18 of 2CPUs  no iowait  no steal time
Free:  RAM 54.61%  Disk / 91.44% /usr 23.47% /boot/efi 100.00% 

ens5       10.250.26.3/19  fe80::4f:a1ff:fe1a:aec6/64  
tunl0       100.96.0.1/32                              


The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
_____________________________________________________________________
WARNING! Your environment specifies an invalid locale.
 The unknown environment variables are:
   LC_CTYPE=UTF-8 LC_ALL=
 This can affect your user experience significantly, including the
 ability to manage packages. You may install the locales by running:

 sudo dpkg-reconfigure locales

 and select the missing language. Alternatively, you can install the
 locales-all package:

 sudo apt-get install locales-all

To disable this message for all users, run:
   sudo touch /var/lib/cloud/instance/locale-check.skip
_____________________________________________________________________

$ 

@tedteng
Copy link
Contributor Author

tedteng commented Oct 19, 2020

Az SSH & subcommand az cli -- PASS

gg az -- -h                                                      
Group
    az
gg ssh shoot--i333878--az-az-001-worker-bt6i6-z3-598c94d869-fpjj9
Warning:
Be aware that you are entering an untrusted environment!
Do not enter credentials or sensitive data within the ssh session that cluster owners should not have access to.

Downloaded id_rsa key
Check Public IP

(1/4) Fetching data from target shoot cluster
Standard
Data fetched from target shoot cluster.

(2/4) Configuring Azure
Opened SSH Port.

Create public ip
20.54.88.160
Waiting 5 s until public ip is available.

Add public ip to nic

Waiting 30 seconds until ports are open.
(3/4) Establishing SSH connection

Warning: Permanently added '20.54.88.160' (ED25519) to the list of known hosts.
  ____               _              _     _                  
 / ___| __ _ _ __ __| | ___ _ __   | |    _ _ __  _   ___  __
| |  _ / _` | '__/ _` |/ _ \ '_ \  | |   | | '_ \| | | \ \/ /
| |_| | (_| | | | (_| |  __/ | | | | |___| | | | | |_| |>  < 
 \____|\__,_|_|  \__,_|\___|_| |_| |_____|_|_| |_|\__,_/_/\_\
Garden Linux 11 (based on Debian GNU/Linux 11)               

@tedteng
Copy link
Contributor Author

tedteng commented Oct 19, 2020

GCP SSH -Pass but gcloud cli -failure.

gg ssh shoot--i333878--az-az-001-worker-bt6i6-z3-598c94d869-fpjj9
Warning:
Be aware that you are entering an untrusted environment!
Do not enter credentials or sensitive data within the ssh session that cluster owners should not have access to.

Downloaded id_rsa key
Check Public IP

(1/4) Fetching data from target shoot cluster
Standard
Data fetched from target shoot cluster.

(2/4) Configuring Azure
Opened SSH Port.

Create public ip
20.54.93.79
Waiting 5 s until public ip is available.

Add public ip to nic

Waiting 30 seconds until ports are open.
(3/4) Establishing SSH connection

Warning: Permanently added '20.54.93.79' (ED25519) to the list of known hosts.
  ____               _              _     _                  
 / ___| __ _ _ __ __| | ___ _ __   | |    _ _ __  _   ___  __
| |  _ / _` | '__/ _` |/ _ \ '_ \  | |   | | '_ \| | | \ \/ /
| |_| | (_| | | | (_| |  __/ | | | | |___| | | | | |_| |>  < 
 \____|\__,_|_|  \__,_|\___|_| |_| |_____|_|_| |_|\__,_/_/\_\
Garden Linux 11 (based on Debian GNU/Linux 11)               

Welcome to shoot--i333878--az-az-001-worker-bt6i6-z3-598c94d869-fpjj9.ku0di1l4wfdutovlmztclf00lc.fx.internal.cloudapp.net  Mon Oct 19 06:51:41 UTC 2020
Linux #1 SMP Debian 5.4.19-1 (2020-02-13) x86_64 up 17 minutes
Load:  3.49, 3.08, 2.30 of 1CPUs  23.19% iowait  no steal time
Free:  RAM 6.45%  Disk / 92.54% /usr 28.08% /boot/efi 100.00% /mnt/resource 94.37% 

eth0       10.250.0.4/16  fe80::20d:3aff:fedd:c955/64  


The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
Last login: Mon Oct 19 06:41:45 2020 from 180.166.22.232

@tedteng
Copy link
Contributor Author

tedteng commented Oct 19, 2020

after checked at least from v21 the gcloud issue already exist open the issue ticket. #396

./gardenctl-darwin-amd64 gcloud compute instances list
ERROR: (gcloud.auth.activate-service-account) Missing required argument [ACCOUNT]: An account is required when using .p12 keys
image

@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 19, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@tedteng tedteng changed the title [WIP]aws.go az.go gcloud.go aws.go az.go gcloud.go Oct 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@tedteng
Copy link
Contributor Author

tedteng commented Oct 19, 2020

The .ci/test is only a temporary solution before we found a new solution as we lack knowledge about ginkgo & gomega now to achieve the goal. I hope we can use ginkgo & gomega in the future.

to use test shell script on local & check before commit
.ci/test local

add test case for aws/az/gcloud cli
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2020
@gardener-robot gardener-robot removed the needs/review Needs review label Oct 19, 2020
@neo-liang-sap
Copy link
Contributor

/LGTM
i haven't test it but based on author's test and discussion with @dansible i will merge it

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Oct 19, 2020
@neo-liang-sap neo-liang-sap merged commit dc3d272 into gardener-attic:master Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
7 participants