-
Notifications
You must be signed in to change notification settings - Fork 42
Conversation
39c31a4
to
b769e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not an acceptable solution. It does not fix the root cause and in addition it re-introduces old code that was replaced with the new getTechnicalID implementation by a reason
- fetch all shoots across all namespaces (which is not necessary)
- fragile
if strings.HasSuffix(namespace.Name, clustername) {
check
This PR only rollback change getTechnicalID to original. which block the neo testing his own code in his local dev environment .I believe this will change it again when To fix the root cause It will be in the ticket issue #354 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @petersutter , this is not acceptable.
@tedteng , please take your time to work on #322 and fix it from root cause, as i mentioned in #344 (review) , we don't have tight release schedule here.
BTW i don't have any urgent testing blocked here, so again, take your time.
/close it as an issue in DEV local environment and not |
What this PR does / why we need it:
rollback change getTechnial in SSH
Which issue(s) this PR fixes:
Fixes #322
Special notes for your reviewer:
Release note: