Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

List orphaned infra resources #340

Merged

Conversation

jfortin-sap-zz
Copy link

@jfortin-sap-zz jfortin-sap-zz commented Sep 23, 2020

What this PR does / why we need it:
Identify orphaned infra resources not found in cluster terraform state
Which issue(s) this PR fixes:
Fixes #252

Special notes for your reviewer:

Release note:

Identify orphaned infra resources not found in cluster terraform state (gardenctl infra orphan list)

@jfortin-sap-zz jfortin-sap-zz requested a review from a team as a code owner September 23, 2020 14:28
@gardener-robot
Copy link

@jfortin-sap Thank you for your contribution.

@gardener-robot-ci-3
Copy link
Contributor

Thank you @jfortin-sap for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@jfortin-sap-zz
Copy link
Author

@neo-liang-sap @tedteng Created new PR with fix

@neo-liang-sap neo-liang-sap added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2020
@neo-liang-sap
Copy link
Contributor

/lgtm
thanks @jfortin-sap !

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 23, 2020
@neo-liang-sap neo-liang-sap merged commit 58485f9 into gardener-attic:master Sep 23, 2020
@petersutter
Copy link
Contributor

@jfortin-sap in the release note you could add a hint which command to run to list orphaned resources

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List orphaned resources
7 participants