This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
refactor curl to use net/http #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
neo-liang-sap
force-pushed
the
curl-to-api
branch
from
80ef067
to
579e38d
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
/lgtm |
petersutter
suggested changes
Aug 25, 2020
neo-liang-sap
force-pushed
the
curl-to-api
branch
from
579e38d
to
b433944
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Merged
|
Please do not amend your commits and force push. Instead just commit every change you do so that I can better keep track what is new and what you have changed, thanks. Once we are done with the review you can then squash it finally. |
Sorry about that, will note this point next time, thanks for reminding! |
petersutter
reviewed
Aug 26, 2020
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
petersutter
approved these changes
Aug 26, 2020
neo-liang-sap
force-pushed
the
curl-to-api
branch
from
9e47b4a
to
7098b12
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
petersutter
reviewed
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refactor curl to use net/http
Which issue(s) this PR fixes:
Fixes #273
Special notes for your reviewer:
Release note: