Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

fix alicloud ssh #201

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

EmoinLanyu
Copy link
Contributor

What this PR does / why we need it:
Previously gardenctl fixed the problem that when doing ssh, an id_rsa.pub key will be created in current folder. However, it was not applied to alicloud provider.
This PR fixes alicloud ssh command and makes it aligned with other providers'.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix the issue that breaks ssh command for provider alicloud.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2020
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added the reviewed/lgtm Has approval for merging label May 28, 2020
@DockToFuture DockToFuture merged commit d422d29 into gardener-attic:master May 28, 2020
@EmoinLanyu EmoinLanyu deleted the fix-alicloud-ssh branch May 28, 2020 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants