Handle properly hibernated Shoots #148

KristianZH · 2019-11-20T13:31:47Z

What this PR does / why we need it:

Show hibernated shoots on gardenctl ls shoots and gardenctl info command.
Handle properly hibernated Shoots for gardenctl shell

Which issue(s) this PR fixes:
Fixes #135

Special notes for your reviewer:
@ialidzhikov @DockToFuture

Release note:

`gardenctl info` does now show also the number of hibernated Shoots per Seeds. `gardenctl ls shoots` now also list whether the Shoot is hibernated.

DockToFuture · 2019-11-20T13:55:03Z

Thank you for the PR, the feature looks pretty nice. Can we also the total number of hibernated shoots to the output of the gardenctl info cmd?

DockToFuture · 2019-11-20T13:59:54Z

Do you also want to add the other two points from #135 to the PR as @ialidzhikov has suggested?

KristianZH · 2019-11-20T14:04:51Z

Can we also the total number of hibernated shoots to the output of the gardenctl info cmd?

Yup, will add it.

Do you also want to add the other two points from #135 to the PR as @ialidzhikov has suggested?

Okay i can rename this PR as WIP for now and to bind it to #135

ialidzhikov

Thanks for the PR.
Can we adapt the info output to be like?

$ g info
Garden: foo
Shoots:
  active: 3
  hibernated: 2
  total: 5
  unscheduled: 0
  aws-bar:
    active: 3
    hibernated: 2
    total: 5

ialidzhikov

Thanks for the PR! Minor nits.

pkg/cmd/info.go

pkg/cmd/shell.go

pkg/cmd/ssh.go

pkg/cmd/utils.go

pkg/cmd/ssh.go

pkg/cmd/info.go

pkg/cmd/shell.go

ialidzhikov · 2019-11-21T18:32:10Z

With #138, gardenctl no longer calls the Shoot kube-apiserver to get the nodes. So the hibernation check here is no longer needed.

ialidzhikov

/approve

KristianZH requested a review from ialidzhikov as a code owner November 20, 2019 13:31

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2019

gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2019

KristianZH changed the title ~~Show hibernated shoots~~ [WIP] Add proper support for hibernated shoots Nov 20, 2019

KristianZH changed the title ~~[WIP] Add proper support for hibernated shoots~~ [WIP] Handle properly hibernated Shoots Nov 20, 2019

KristianZH added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 20, 2019

KristianZH force-pushed the show-hibernated-shoots branch from fec67fe to 8c84459 Compare November 21, 2019 08:16

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

KristianZH changed the title ~~[WIP] Handle properly hibernated Shoots~~ Handle properly hibernated Shoots Nov 21, 2019

KristianZH removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Nov 21, 2019

KristianZH requested a review from DockToFuture November 21, 2019 08:17

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

ialidzhikov reviewed Nov 21, 2019

View reviewed changes

KristianZH force-pushed the show-hibernated-shoots branch from 8c84459 to b347b87 Compare November 21, 2019 11:33

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

KristianZH requested a review from ialidzhikov November 21, 2019 11:33

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

ialidzhikov reviewed Nov 21, 2019

View reviewed changes

pkg/cmd/info.go Outdated Show resolved Hide resolved

pkg/cmd/shell.go Outdated Show resolved Hide resolved

pkg/cmd/shell.go Show resolved Hide resolved

pkg/cmd/shell.go Outdated Show resolved Hide resolved

pkg/cmd/ssh.go Outdated Show resolved Hide resolved

KristianZH force-pushed the show-hibernated-shoots branch from b347b87 to 2d1b359 Compare November 21, 2019 14:29

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

ialidzhikov reviewed Nov 21, 2019

View reviewed changes

KristianZH force-pushed the show-hibernated-shoots branch from 2d1b359 to 05ef82d Compare November 21, 2019 15:40

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

KristianZH force-pushed the show-hibernated-shoots branch from 05ef82d to 4021a42 Compare November 21, 2019 15:46

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

ialidzhikov force-pushed the show-hibernated-shoots branch from 4021a42 to 9a1e04c Compare November 21, 2019 17:18

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2019

ialidzhikov force-pushed the show-hibernated-shoots branch from 9a1e04c to 43209c7 Compare November 21, 2019 18:30

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

Show hibernated shoots

b4d0c46

ialidzhikov force-pushed the show-hibernated-shoots branch from 43209c7 to b4d0c46 Compare November 21, 2019 18:54

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2019

ialidzhikov approved these changes Nov 21, 2019

View reviewed changes

ialidzhikov merged commit e729c4a into gardener-attic:master Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle properly hibernated Shoots #148

Handle properly hibernated Shoots #148

KristianZH commented Nov 20, 2019 •

edited by ialidzhikov

Loading

DockToFuture commented Nov 20, 2019

DockToFuture commented Nov 20, 2019

KristianZH commented Nov 20, 2019 •

edited

Loading

ialidzhikov left a comment •

edited by KristianZH

Loading

ialidzhikov left a comment

ialidzhikov commented Nov 21, 2019

ialidzhikov left a comment

Handle properly hibernated Shoots #148

Handle properly hibernated Shoots #148

Conversation

KristianZH commented Nov 20, 2019 • edited by ialidzhikov Loading

DockToFuture commented Nov 20, 2019

DockToFuture commented Nov 20, 2019

KristianZH commented Nov 20, 2019 • edited Loading

ialidzhikov left a comment • edited by KristianZH Loading

Choose a reason for hiding this comment

ialidzhikov left a comment

Choose a reason for hiding this comment

ialidzhikov commented Nov 21, 2019

ialidzhikov left a comment

Choose a reason for hiding this comment

KristianZH commented Nov 20, 2019 •

edited by ialidzhikov

Loading

KristianZH commented Nov 20, 2019 •

edited

Loading

ialidzhikov left a comment •

edited by KristianZH

Loading