Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Allow multiple shell cmds simultaneously #128

Merged

Conversation

ialidzhikov
Copy link
Contributor

What this PR does / why we need it:

  • Allow gardenctl shell command to be able to run root pods on multiple nodes simultaneously. Currently the second shell command overrides and interrupts the session of the first one.
  • Vendor gardener/[email protected]

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`gardenctl shell` can now run root pods on multiple nodes simultaneously.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 21, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 21, 2019
Copy link
Contributor

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ialidzhikov ialidzhikov merged commit c24247a into gardener-attic:master Oct 21, 2019
@ialidzhikov ialidzhikov deleted the enh/allow-multiple-shells branch October 21, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants