Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Unified ImageID for creating the bastion #112

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

KristianZH
Copy link

@KristianZH KristianZH commented Aug 15, 2019

What this PR does / why we need it:
Unified ImageID for creating the bastion. This will help us for determining the ssh command.
The image is fetched from the ControllerRegistration of the Cloud Provider.
Soon there will be a new user for the nodes, called gardener. After it we will simply ssh with bastion user core and node user gardener

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
@ialidzhikov @DockToFuture @vpnachev

-->

Bastion host is created with `coreos` imageID.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 15, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 15, 2019
pkg/cmd/ssh.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2019
pkg/cmd/ssh.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 16, 2019
Copy link
Contributor

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@DockToFuture DockToFuture merged commit fa4f844 into gardener-attic:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants