Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Update spf13/cobra #110

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Update spf13/cobra #110

merged 1 commit into from
Aug 14, 2019

Conversation

vpnachev
Copy link
Contributor

What this PR does / why we need it:
Update spf13/cobra to fix $ gardenctl target <garden|seed|shoot|project> <tab><tab>

With #107 the version of spf13/cobra was downgraded with quite old one, that supports only __custom_func name which may be overwritten by lately sourced completion script.

This is why we have __gardenctl_custom_func but it requires v0.0.4+ of spf13/cobra. https://github.com/gardener/gardenctl/blob/91d3d155167651b6464b15fee7f5091c53ce8b55/pkg/cmd/root.go#L72-L80
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The auto completion for `target` is working again.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 14, 2019
@vpnachev vpnachev added area/usability Usability related component/gardenctl Gardener CLI exp/beginner Issue that requires only basic skills kind/bug Bug needs/lgtm Needs approval for merging needs/review Needs review platform/all size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 14, 2019
ialidzhikov
ialidzhikov approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ialidzhikov ialidzhikov merged commit f26448a into gardener-attic:master Aug 14, 2019
@vpnachev vpnachev deleted the update-spf13-cobra branch August 14, 2019 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/usability Usability related component/gardenctl Gardener CLI exp/beginner Issue that requires only basic skills kind/bug Bug needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/all size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpnachev @ialidzhikov @gardener-robot-ci-1