Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to submit an HTML file to JS3 #63

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Oct 8, 2022

Closes #62

Description

Students should be able to submit an HTML file for the 10th challenge. Currently, when they try to submit, they get:

✖ A valid challenge file could not be found. Make sure the file is not renamed and it has the following format: 1.js, 2.js, 3.js, ...etc

Fix

Add a condition to determine if the user is submitting for JS3 and whether the files have .js or .html extensions.

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #63 (41e3655) into master (ca3de47) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          257       262    +5     
  Branches        35        37    +2     
=========================================
+ Hits           257       262    +5     
Impacted Files Coverage Δ
src/messages.ts 100.00% <ø> (ø)
src/util/dynamicMessages.ts 100.00% <ø> (ø)
src/util/git.ts 100.00% <100.00%> (ø)
src/util/prompt.ts 100.00% <100.00%> (ø)

@flacial
Copy link
Member Author

flacial commented Oct 8, 2022

Students can't submit one JS and another HTML file to JS3. This will be fixed in a subsequent PR.

@flacial flacial merged commit 74c0474 into garageScript:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to submit an HTML file to JS3
2 participants