Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(1): Add links for easy access to challenges and submissions #3034

Conversation

flacial
Copy link
Member

@flacial flacial commented Jun 1, 2023

Overview

The ability to link the challenges/submissions is achieved by wrapping the name of the challenge with a Link component that has an href with a query string that looks like curriculum/[lessonSlug]?challenge={ChallengeId}. In order to provide the challenge ID to this snippet, we'll update the submission fragment to include the field challenge { id }.

Changes

  • Update test snapshots
  • Update GraphQL index
  • Update the submission fragment to include the challenge ID field
  • Update the dummy data of the submission query

Related PRs

@vercel
Copy link

vercel bot commented Jun 1, 2023

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #3034 (339fe12) into master (de2dfd1) will not change coverage.
The diff coverage is n/a.

❗ Current head 339fe12 differs from pull request most recent head 06becad. Consider uploading reports for the commit 06becad to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3034   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines         3608      3608           
  Branches       981       981           
=========================================
  Hits          3608      3608           
Impacted Files Coverage Δ
__dummy__/getPreviousSubmissionsData.ts 100.00% <ø> (ø)
__dummy__/submission.ts 100.00% <ø> (ø)
graphql/queries/fragments/submissionsFragment.ts 100.00% <ø> (ø)

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 8:52am

@flacial flacial added this pull request to the merge queue Jun 3, 2023
Merged via the queue into garageScript:master with commit fad9f5c Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants