Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlapping act() calls error on SubmissionComments.test.js #2887

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

scotthallock
Copy link
Collaborator

@scotthallock scotthallock commented Apr 5, 2023

Overview

When running the test suites, SubmissionComments.test.js logs two identical console errors:

Screenshot 2023-04-05 at 10 56 45 AM

Changes

  • In the it('should allow user to edit comment and discard changes when edit button is pressed, but not edit more than 1 comment in a chain', ... ) test, remove the unneccessary nested waitFor() calls.
  • The findByText() gets an await keyword in front of it because it is async
  • The test suite no longer logs errors on the console:

Screenshot 2023-04-05 at 6 22 11 PM

Notes

@vercel
Copy link

vercel bot commented Apr 5, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2887 (18e8778) into master (60d8d48) will not change coverage.
The diff coverage is n/a.

❗ Current head 18e8778 differs from pull request most recent head 8601a30. Consider uploading reports for the commit 8601a30 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2887   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines         3576      3576           
  Branches       970       970           
=========================================
  Hits          3576      3576           

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 11:55pm

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one fixing these concerning console screams!

@scotthallock scotthallock added this pull request to the merge queue Apr 6, 2023
Merged via the queue into garageScript:master with commit 0bedb20 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants