Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MdInput stories and update snapshots #2871

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

scotthallock
Copy link
Collaborator

Overview

This PR fixes the broken input on the MdInput component's stories, and also add new stories.

The MdInput's value and onChange props are passed from the parent component's state. The parent component is ReviewCard, and the ReviewCard stories do allow for user input in the MdInput component.

Changes

  • Added a Template to the MdInput.stories.tsx file which has a state hook to mock the parent component state.
  • Added a new stories, which better showcase how the component will render markdown input and HTML input.

Notes

Related issues

@vercel
Copy link

vercel bot commented Apr 1, 2023

@scotthallock is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@scotthallock
Copy link
Collaborator Author

This PR also deletes the _WithSubmissionButtons story, because Storybook is meant for developing and showcasing components in isolation.

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #2871 (56c2654) into master (8f2320d) will not change coverage.
The diff coverage is n/a.

❗ Current head 56c2654 differs from pull request most recent head 6590243. Consider uploading reports for the commit 6590243 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2871   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines         3576      3576           
  Branches       970       970           
=========================================
  Hits          3576      3576           

Copy link
Member

@flacial flacial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
c0d3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2023 10:13am

@scotthallock scotthallock added this pull request to the merge queue Apr 1, 2023
Merged via the queue into garageScript:master with commit f955ed8 Apr 1, 2023
@JasirZaeem
Copy link
Member

@all-contributors please add @scotthallock for code

@allcontributors
Copy link
Contributor

@JasirZaeem

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 5848

@JasirZaeem
Copy link
Member

@all-contributors please add @scotthallock for code

@allcontributors
Copy link
Contributor

@JasirZaeem

I've put up a pull request to add @scotthallock! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦄 Done
Development

Successfully merging this pull request may close these issues.

MdInput stories do not allow for user input
4 participants