Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow using password inputs #2673

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Jan 5, 2023

Motivation

Currently, there's no way to make an input type password. This is preventing us from completing the password section (2nd task).

Changes

  • Update FormCard component's option type to take an optional inputValue which is set to password

Screenshot

image

View changes

  • Storybook/FormCard

@vercel
Copy link

vercel bot commented Jan 5, 2023

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 0:21AM (UTC)

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #2673 (07efe16) into master (9e06e4f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2673   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       189           
  Lines         3513      3514    +1     
  Branches       974       975    +1     
=========================================
+ Hits          3513      3514    +1     
Impacted Files Coverage Δ
components/FormCard.tsx 100.00% <100.00%> (ø)

@flacial flacial merged commit b973dfa into garageScript:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants