feat(admin): Create challenges page #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
flacial
commented
Nov 5, 2022
| @@ -162,7 +161,12 @@ const ModulesPage = ({ modules, lessonId, refetch }: ModulesPageProps) => { | |||
| <div className={styles.container__modulesPanel}> | |||
| <AdminLessonSideNav | |||
| title="Modules" | |||
| items={modules} | |||
| items={modules.map(module => ({ | |||
There was a problem hiding this comment.
AdminLessonSideNav takes a specific object. For it to work, we're passing what it expects.
flacial
commented
Nov 5, 2022
| fetchPolicy: 'no-cache' | ||
| }) | ||
|
|
||
| const { data: modulesData, refetch: refetchModules } = useModulesQuery({ |
There was a problem hiding this comment.
To reduce the number of queries sent, we can only send a request to get x query (e.g, modules) when the user goes to its page. Let me know what you think.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 186 186
Lines 3324 3348 +24
Branches 883 889 +6
=========================================
+ Hits 3324 3348 +24
|
SlyBouhafs
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2081
Description
This PR aims at adding the page that'll be used to create and edit the challenges.
Page image
Testing
/admin/lessons/js0/challengesSAVE CHANGES→ Make sure it got updated correctlyADD NEW MODULEat the bottom of the sidebarorderas 0 → Make sure it appears as the first item in the sidebarIssues
The sidebar text should be
ADD NEW CHALLENGE&NO CHALLENGESinstead of modules. This will be fixed in a subsequent PR.