-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign AdminLessonExerciseCard #2437
Redesign AdminLessonExerciseCard #2437
Conversation
…manage-exercises-tab
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2437 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 185 185
Lines 3292 3307 +15
Branches 874 878 +4
=========================================
+ Hits 3292 3307 +15
|
Can you add the relevant path for the admin exercises page? |
We don't have this page yet. It'll be added in a subsequent PR |
I addressed the comments in the last commit. This is how it now looks: When the admin click the username, it'll open the user's profile page. |
Nice, prepending an |
I like the idea of changing the remove button color to red, but the unflag is suitable because purple represents a primary action, but at the same time it's overused in the component. I'll give changing the unflag to green a shot. It terms of being obvious, I think with colors other than purple, they're quite obvious. |
@SlyBouhafs What do you think? I chose orange because green represents something positive, something good. While orange is like "Are you sure you want to unflag this?". |
Looks good to me! |
Related to #1990
Description
This PR redesign the
AdminLessonExerciseCard
to achieve:Visual difference
Before
After