Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign AdminLessonExerciseCard #2437

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Oct 18, 2022

Related to #1990

Description

This PR redesign the AdminLessonExerciseCard to achieve:

  1. No extra space between the paragraphs when they're short
  2. Looks good on mobile
  3. Admin can copy Discord username

Visual difference

Before image image
After image image

@vercel
Copy link

vercel bot commented Oct 18, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 0:22AM (UTC)

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #2437 (04900d4) into master (5cefffa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2437   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines         3292      3307   +15     
  Branches       874       878    +4     
=========================================
+ Hits          3292      3307   +15     
Impacted Files Coverage Δ
...mponents/admin/lessons/AdminLessonExerciseCard.tsx 100.00% <100.00%> (ø)
...es/admin/lessons/[lessonSlug]/[pageName]/index.tsx 100.00% <100.00%> (ø)

@SlyBouhafs
Copy link
Member

Can you add the relevant path for the admin exercises page?

@flacial
Copy link
Member Author

flacial commented Oct 20, 2022

Can you add the relevant path for the admin exercises page?

We don't have this page yet. It'll be added in a subsequent PR

@SlyBouhafs
Copy link
Member

SlyBouhafs commented Oct 20, 2022

We don't have this page yet. It'll be added in a subsequent PR

Oh ok, i wanted to leave a few comments on it via the Vercel comment feature. I left a few comments on this image instead:

adminexercisepage

@flacial
Copy link
Member Author

flacial commented Oct 21, 2022

We don't have this page yet. It'll be added in a subsequent PR

Oh ok, i wanted to leave a few comments on it via the Vercel comment feature. I left a few comments on this image instead:

I addressed the comments in the last commit. This is how it now looks:

Image image

When the admin click the username, it'll open the user's profile page.

@SlyBouhafs
Copy link
Member

SlyBouhafs commented Oct 22, 2022

I addressed the comments in the last commit. This is how it now looks:

Nice, prepending an @ was a good idea! I also think that we should make the unflag and remove exercise buttons a bit a more obvious, should they look like button or links? Should they have the same color? The remove button should probably be in red and the unflag maybe green?

@flacial
Copy link
Member Author

flacial commented Oct 23, 2022

I addressed the comments in the last commit. This is how it now looks:

Nice, prepending an @ was a good idea! I also think that we should make the unflag and remove exercise buttons a bit a more obvious, should they look like button or links? Should they have the same color? The remove button should probably be in red and the unflag maybe green?

I like the idea of changing the remove button color to red, but the unflag is suitable because purple represents a primary action, but at the same time it's overused in the component. I'll give changing the unflag to green a shot.

It terms of being obvious, I think with colors other than purple, they're quite obvious.

@flacial
Copy link
Member Author

flacial commented Oct 23, 2022

@SlyBouhafs What do you think?

197373705-8dd86389-69d2-4c7e-b2f9-a955397e9fe0

I chose orange because green represents something positive, something good. While orange is like "Are you sure you want to unflag this?".

@SlyBouhafs
Copy link
Member

Looks good to me!

@flacial flacial merged commit 8353ee0 into garageScript:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants