Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DOJO/mentor): Only display mentor created exercises #2385

Conversation

flacial
Copy link
Member

@flacial flacial commented Oct 2, 2022

Related to #2029

Description

Merging this PR will update the mentor page under /curriculum/[lessonSlug]/mentor to only show the exercises that the mentor created by comparing the exercise author's id to the user session id.

Testing

  • Create a module from /admin/lessons/js0/modules
  • Create an exercise from /curriculum/js0/mentor/addExercise
  1. Go to /curriculum/js0/mentor
  2. Confirm the exercise you created are the only ones appearing

Bugs

While pushing, I noticed a flaky test caused by this line in the Exercises page. I couldn't trace back what caused it.

@vercel
Copy link

vercel bot commented Oct 2, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
c0d3-app ✅ Ready (Inspect) Visit Preview 5 resolved Oct 3, 2022 at 0:25AM (UTC)

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #2385 (4dbf634) into master (abe2aca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines         3272      3275    +3     
  Branches       863       865    +2     
=========================================
+ Hits          3272      3275    +3     
Impacted Files Coverage Δ
__dummy__/getExercisesData.ts 100.00% <ø> (ø)
...rriculum/[lessonSlug]/mentor/addExercise/index.tsx 100.00% <100.00%> (ø)
pages/curriculum/[lessonSlug]/mentor/index.tsx 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants